Skip to content

Use Flickwerk for patches #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Dec 17, 2024

Summary

This moves the decorators to the appropriate places according to the Flickwerk Readme.

@mamhoff mamhoff force-pushed the flickwerk branch 9 times, most recently from b3500d1 to 9659b54 Compare January 14, 2025 10:52
@mamhoff
Copy link
Contributor Author

mamhoff commented Jan 16, 2025

These specs would pass if solidusio/solidus_support#94 was in a released solidus_support version. This gems runs the specs in a new bundle environment in which I can't set the source for solidus_support to a specific branch.

@tvdeyen tvdeyen changed the title Flickwerk-style patches Use Flickwerk for patches Feb 27, 2025
Prior to this commit, the user class would be set to
`Spree::LegacyUser`, but the presence of `solidus_auth_devise` would
reset it to `Spree::User` later. That's not good for registering patches
to the configured user class.
This patch depends on `solidus_backend` to be present, and should thus
live in lib/patches/backend.
Flickwerk patch support is only present from 0.13.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants