Add device data collection #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmendoza
commented
Mar 2, 2023
| @@ -7,6 +7,7 @@ SolidusBraintree.HostedForm.prototype.initialize = function() { | |||
| this.client = SolidusBraintree.createClient({ | |||
| paymentMethodId: this.paymentMethodId, | |||
| useThreeDSecure: (typeof(window.threeDSecureOptions) !== 'undefined'), | |||
| useDataCollector: true, | |||
There was a problem hiding this comment.
@SyborgStudios I removed the IS_FRONTEND const since we now have separate hosted_form JS files for frontend and backend.
There was a problem hiding this comment.
Awesome. I was not happy with it anyways.
gsmendoza
commented
Mar 2, 2023
|
@SyborgStudios I made the following minor changes to your PR:
Can you review? |
kennyadsl
approved these changes
Mar 2, 2023
elia
approved these changes
Mar 2, 2023
waiting-for-dev
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Thanks, @gsmendoza, good job! I left two minor suggestions but feel free to merge.
Closes #115. This commit adds device data collection. See: https://developer.paypal.com/braintree/docs/guides/premium-fraud-management-tools/device-data-collection
gsmendoza
force-pushed
the
gsmendoza/115-add-device-data-collection
branch
from
d4fc255 to
3817011
Compare
|
@SyborgStudios I'm merging this now :) |
This was referenced Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #115.
Revision of #103.
This commit adds device data collection.
See: https://developer.paypal.com/braintree/docs/guides/premium-fraud-management-tools/device-data-collection
Testing
Confirmed after checking out with Braintree Credit Card payment method:
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: