Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use custom routes #237

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Only use custom routes #237

wants to merge 6 commits into from

Commits on Dec 23, 2022

  1. Remove extra space

    @cpfergus1 @elia
    cpfergus1 authored and elia committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    5e71eec View commit details
    Browse the repository at this point in the history

  2. Only use custom routes 

    Using both devise generated routes and custom ones is confusing.

As an example: when failing authentication, the devise route would
send the user to "new_spree_user_session_path", however we want our
users to be redirected to "/login." This commit deprecates the route
and sends users to "/login."
    @cpfergus1 @elia
    cpfergus1 authored and elia committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    bd2e854 View commit details
    Browse the repository at this point in the history

  3. Show a deprecation message for legacy routes

    @elia
    elia committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    326ab9e View commit details
    Browse the repository at this point in the history

  4. Install dependencies in CI jobs 

    Namely, libvips.
    @elia
    elia committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    ef6c4ba View commit details
    Browse the repository at this point in the history

  5. elia+kennyadsl/fix-routes: [wip]

    @elia
    elia committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    93a73ec View commit details
    Browse the repository at this point in the history

  6. elia+kennyadsl/fix-routes: [wip]

    @elia
    elia committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    0dc2dd7 View commit details
    Browse the repository at this point in the history