Skip to content

Fix Rubocop offense #6196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tvdeyen merged 1 commit into from
Mar 27, 2025
Merged

Fix Rubocop offense #6196

tvdeyen merged 1 commit into from
Mar 27, 2025

Conversation

@mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Mar 27, 2025

Rubocop updated, and we have new offenses.

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@mamhoff mamhoff requested a review from a team as a code owner March 27, 2025 11:32
@github-actions github-actions bot added changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem changelog:solidus_promotions Changes to the solidus_promotions gem labels Mar 27, 2025
@mamhoff
Fix Rubocop offense
4e76d76 
Rubocop updated, and we have new offenses.
@mamhoff mamhoff force-pushed the fix-rubocop-offense branch from f9eecc4 to 4e76d76 Compare March 27, 2025 11:32
tvdeyen
tvdeyen approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏🏻

@tvdeyen tvdeyen enabled auto-merge March 27, 2025 11:33
@tvdeyen tvdeyen disabled auto-merge March 27, 2025 15:23
@tvdeyen tvdeyen merged commit 0fea9df into solidusio:main Mar 27, 2025
12 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees

No one assigned

Labels

changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem changelog:solidus_promotions Changes to the solidus_promotions gem

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mamhoff @tvdeyen