Add new order events #6170
Merged
Add new order events #6170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This event fires when the order `#cancel!` event is fired as part of the stock order state machine events. Co-Authored-By: Adam Mueller <adam@super.gd>
This event fires when `OrderCancellations#short_ship` is fired when an an inventory unit is canceled from an order. Co-Authored-By: Adam Mueller <adam@super.gd>
This adds a `:carton_shipped` event that is published whenever `OrderShipping#ship` succeeds to mark a carton as shipped. Co-Authored-By: Adam Mueller <adam@super.gd>
github-actions
bot
added
the
changelog:solidus_core
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6170 +/- ##
=======================================
Coverage 88.81% 88.81%
=======================================
Files 835 835
Lines 18153 18156 +3
=======================================
+ Hits 16122 16125 +3
Misses 2031 2031 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds three new order-related events to the event system:
:order_canceled:order_short_shipped:carton_shippedWe were motivated to make this change so that we can, in the future, send transaction emails for these events via subscribers. We already do this for order confirmation emails and reimbursement emails. Aligning all mailers to work the same way seems like an improvement.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: