4.2: Limit concurrent-ruby to < 1.3.5
#6077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:repository
mamhoff
force-pushed
the
v4-2-rails-branch
branch
2 times, most recently
from
b34611e to
2bfd23e
Compare
github-actions
bot
added
changelog:solidus_core
mamhoff
changed the title
concurrent-ruby to < 1.3.5
tvdeyen
reviewed
Jan 16, 2025
| s.add_dependency 'awesome_nested_set', '~> 3.3' | ||
| s.add_dependency 'cancancan', ['>= 2.2', '< 4.0'] | ||
| s.add_dependency 'carmen', '~> 1.1.0' | ||
| s.add_dependency 'concurrent-ruby', '< 1.3.5' |
Member
There was a problem hiding this comment.
Can we add a comment to the Rails issue?
jarednorman
approved these changes
Jan 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4.2 #6077 +/- ##
=======================================
Coverage 88.86% 88.86%
=======================================
Files 607 607
Lines 14752 14752
=======================================
Hits 13109 13109
Misses 1643 1643 ☔ View full report in Codecov by Sentry. |
The `concurrent-ruby` gem drops a dependency on the `logger` gem, which Rails 7.0 implicitly depends on. Rails 7.0 is out of bugfix maintenance, so we won't see another release that has this bug fixed, so for Solidus 4.2 and 4.1 let's just limit `concurrent-ruby` to versions that *do* depend on `logger`.
mamhoff
force-pushed
the
v4-2-rails-branch
branch
from
2bfd23e to
62d5c3d
Compare
jarednorman
approved these changes
Jan 17, 2025
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mamhoff
added a commit
to mamhoff/solidus_reviews
that referenced
this pull request
Feb 12, 2025
This restriction is already in the respective solidus branches. See: 4.2: solidusio/solidus#6077 4.1: solidusio/solidus#6087
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
concurrent-rubygem drops a dependency on theloggergem, whichRails 7.0 implicitly depends on. Rails 7.0 is out of bugfix maintenance,
so we won't see another release that has this bug fixed, so for Solidus
4.2 and 4.1 let's just limit
concurrent-rubyto versions that dodepend on
logger.See rails/rails#54264
This approach has the advantage that we don't have to change the spec setup for every extension, because Solidus 4.2's dependencies take care of the problem.