Skip to content

Pin view_component to < 3.21.0 #6048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tvdeyen merged 1 commit into from
Jan 3, 2025
Merged

Pin view_component to < 3.21.0 #6048

tvdeyen merged 1 commit into from
Jan 3, 2025

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 20, 2024 •
edited
Loading

@tvdeyen
Pin view_component to < 3.21.0
e0da385 
3.21.0 introduced a bug with testing view components.
@tvdeyen tvdeyen requested a review from a team as a code owner December 20, 2024 14:41
@tvdeyen tvdeyen mentioned this pull request Dec 20, 2024
Closed
3 tasks
@codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.82%. Comparing base (9234436) to head (e0da385).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6048   +/-   ##
=======================================
  Coverage   87.82%   87.82%           
=======================================
  Files         477      477           
  Lines       11670    11670           
=======================================
  Hits        10249    10249           
  Misses       1421     1421

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen mentioned this pull request Dec 20, 2024
Merged
13 tasks
@tvdeyen tvdeyen merged commit 9aa24a5 into main Jan 3, 2025
16 checks passed
@tvdeyen tvdeyen deleted the lock-view_component branch January 3, 2025 15:51
mamhoff added a commit to mamhoff/solidus that referenced this pull request Jan 3, 2025
@mamhoff
Revert "Merge pull request solidusio#6048 from solidusio/lock-view_co…
39c9c02 
…mponent"

This reverts commit 9aa24a5, reversing
changes made to 9234436.
mamhoff added a commit to mamhoff/solidus that referenced this pull request Jan 3, 2025
@mamhoff
Revert "Merge pull request solidusio#6048 from solidusio/lock-view_co…
7bd0860 
…mponent"

This reverts commit 9aa24a5, reversing
changes made to 9234436.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adammathys adammathys adammathys approved these changes

Assignees

No one assigned

Labels

changelog:solidus_admin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tvdeyen @adammathys