Skip to content

tests: Give even more dialogs more time to open in tests #6017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvdeyen merged 1 commit into from
Dec 6, 2024
Merged

tests: Give even more dialogs more time to open in tests #6017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions admin/spec/features/adjustment_reasons_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down Expand Up @@ -76,7 +76,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down
4 changes: 2 additions & 2 deletions admin/spec/features/refund_reasons_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down Expand Up @@ -73,7 +73,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down
4 changes: 2 additions & 2 deletions admin/spec/features/return_reasons_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down Expand Up @@ -75,7 +75,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down
4 changes: 2 additions & 2 deletions admin/spec/features/roles_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down Expand Up @@ -130,7 +130,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down
4 changes: 2 additions & 2 deletions admin/spec/features/shipping_categories_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down Expand Up @@ -73,7 +73,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down
4 changes: 2 additions & 2 deletions admin/spec/features/store_credit_reasons_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down Expand Up @@ -73,7 +73,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down
2 changes: 1 addition & 1 deletion admin/spec/features/tax_categories_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

it "closing the modal keeps query params" do
within("dialog") { click_on "Cancel" }
expect(page).not_to have_selector("dialog")
expect(page).not_to have_selector("dialog", wait: 5)
expect(page.current_url).to include(query)
end

Expand Down
Loading