Add filtering by store to orders index component #5870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the legacy admin the order search supported a filter by store. This behaviour is not in the new admin yet, so we're introducing it with this change. Co-authored-by: Harmony Evangelina <harmony@super.gd> Co-authored-by: Tom Van Manen <tom@super.gd>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5870 +/- ##
=======================================
Coverage 89.24% 89.24%
=======================================
Files 754 754
Lines 17533 17533
=======================================
Hits 15647 15647
Misses 1886 1886 ☔ View full report in Codecov by Sentry. |
adammathys
approved these changes
Oct 11, 2024
MadelineCollier
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the legacy admin the order search supported a filter by store. This
behaviour is not in the new admin yet, so we're introducing it with this
change.
This PR addresses part of the concerns raised in #5614.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: