Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker default settings improvements #5868

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

nvandoorn
Copy link
Contributor

@nvandoorn nvandoorn commented Oct 9, 2024

Summary

Just a few small changes to default Docker settings to provide a better experience.

  1. The shared memory change is to prevent feature specs from crashing after exceeding the previous limit of 256MB, so we double it to 512MB for now.
  2. Rails version < 7.1 has issues with our test suite and the spelling of behaviour vs behavior, so we default to Rails 7.1.0 or greater now.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

nvandoorn and others added 2 commits October 9, 2024 14:48
Prior to this change, we were seeing some crashes running feature specs
after exceeding the 256MB shared memory limit.

Co-authored-by: An Stewart <andrew@super.gd>
There is an incompatibility between our test suite and Rails versions `<
7.1.0`, so we provide `7.1.0` as the new default version.

Co-authored-by: An Stewart <andrew@super.gd>
@nvandoorn nvandoorn requested a review from a team as a code owner October 9, 2024 21:59
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Oct 9, 2024
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@tvdeyen tvdeyen merged commit b07465b into solidusio:main Oct 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants