Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Shipping Categories edit/update #5817

Merged

Conversation

MadelineCollier
Copy link
Contributor

@MadelineCollier MadelineCollier commented Aug 8, 2024

Summary

This PR finishes off the excellent work by Loic that was left in draft on #5723
and includes an updated spec.

This PR follows the work started on #5718 where Shipping categories creation was implemented. This PR adds the edit/update functionality for shipping categories.
The issue is #5720

The attached video shows the functionality visually:

Screen.Recording.2024-08-08.at.7.14.00.PM.mov

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@MadelineCollier MadelineCollier requested a review from a team as a code owner August 8, 2024 17:19
@MadelineCollier MadelineCollier changed the title Edit/Update shipping categories via new admin UI [Admin] Shipping Categories edit/update Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.78%. Comparing base (3e8be72) to head (9398e80).

Files Patch % Lines
...rs/solidus_admin/shipping_categories_controller.rb 70.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5817      +/-   ##
==========================================
- Coverage   88.80%   88.78%   -0.02%     
==========================================
  Files         732      733       +1     
  Lines       17088    17114      +26     
==========================================
+ Hits        15175    15195      +20     
- Misses       1913     1919       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadelineCollier MadelineCollier merged commit 0db8839 into solidusio:main Aug 12, 2024
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants