Move adjustment promotion code id to legacy promotions #5800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This had some copy-pasta, and the requiring the engine requires requiring the gem first.
SolidusFriendlyPromotions does not store promotion code IDs on adjustments, and it does not need to: The promotion code is stored on the `friendly_order_promotions` join table between promotion and order, and adjustments and promotion codes can be joined between that table and the adjustments' source. This fixes the build on solidus_friendly_promotions currently, because what that gem does it simply make `require_promotion_code` return `false` for adjustments created with the new promotion system. This change makes the validation self-contained for adjustments from the `legacy_promotions` gem.
It's always set to nil, so it doesn't matter for the specs in question, and we can just not specify it.
If `solidus_legacy_promotions` is loaded, we can be sure that the column exists.
This moves the column into solidus_legacy_promotions, which is the only place it's used at.
github-actions
bot
added
changelog:solidus_api
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5800 +/- ##
=======================================
Coverage 88.78% 88.78%
=======================================
Files 731 731
Lines 17053 17057 +4
=======================================
+ Hits 15140 15144 +4
Misses 1913 1913 ☔ View full report in Codecov by Sentry. |
kennyadsl
approved these changes
Jun 24, 2024
tvdeyen
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Historically, adjustments did not know about their promotion code ID, and solidus_friendly_promotions joins over the
friendly_order_promotionsjoin table instead. This column is part of the legacy promotion system.