Skip to content

Require legacy promotion configuration in legacy_promotions#5796

Merged
tvdeyen merged 1 commit intosolidusio:mainfrom
mamhoff:do-not-load-legacy-config-in-spree-core
Jun 18, 2024
Merged

Require legacy promotion configuration in legacy_promotions#5796
tvdeyen merged 1 commit intosolidusio:mainfrom
mamhoff:do-not-load-legacy-config-in-spree-core

Conversation

@mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Jun 18, 2024

This oversight breaks the specs of solidus_support.

This oversight breaks the specs of `solidus_support`.
@mamhoff mamhoff requested a review from a team as a code owner June 18, 2024 12:15
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Jun 18, 2024
@codecov
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (8b77a17) to head (99e525e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5796   +/-   ##
=======================================
  Coverage   88.92%   88.92%           
=======================================
  Files         718      718           
  Lines       16939    16939           
=======================================
  Hits        15063    15063           
  Misses       1876     1876           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit e582263 into solidusio:main Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants