[Admin] Add the ability to configure batch action confirmation #5702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forkata
force-pushed
the
feature/solidus_admin/add-batch-action-confirmation
branch
from
4cbd7c5
to
83d0141
Compare
forkata
changed the title
This change introduces a new boolean configuration on the `BatchAction` struct that would allow users of the `UI::Table` component to specify if a batch action requires confirmation. This change enables this new behaviour on the products index batch actions as a proof of concept. Co-authored-by: Kendra Riga <kendra@super.gd> Co-authored-by: Cameron Day <cameron@super.gd>
This change adds proper pluralization in the confirm dialog for the resource being modified. Previously the dialog always used the plural version of the resource.
forkata
force-pushed
the
feature/solidus_admin/add-batch-action-confirmation
branch
from
83d0141
to
2e70faf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5702 +/- ##
=======================================
Coverage 88.92% 88.92%
=======================================
Files 700 700
Lines 16655 16663 +8
=======================================
+ Hits 14810 14818 +8
Misses 1845 1845 ☔ View full report in Codecov by Sentry. |
|
Thanks @forkata 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change introduces a new boolean configuration on the
BatchActionstruct that would allow users of theUI::Tablecomponent to specify if a batch action requires confirmation.This change enables this new behaviour on the products index batch actions as a proof of concept.
This is a draft because we haven't added any tests yet, but if this approach looks reasonable we can do that as well.Update: Specs have been updated and passing now.
Issue https://github.com/orgs/solidusio/projects/12/views/1?pane=issue&itemId=52056191
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed:
Screenshots