Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SolidusAdmin's testing support code require-able #5700

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Mar 18, 2024

Summary

I need to move some of SolidusAdmin's specs into
solidus_legacy_promotions. When doing that, it's necessary to require these, so it'd be nice if they lived in lib/.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

I need to move some of SolidusAdmin's specs into
solidus_legacy_promotions. When doing that, it's necessary to require
these, so it'd be nice if they lived in `lib/`.
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.93%. Comparing base (1f42077) to head (4101d91).
Report is 1 commits behind head on main.

Files Patch % Lines
...b/solidus_admin/testing_support/feature_helpers.rb 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5700      +/-   ##
==========================================
+ Coverage   88.92%   88.93%   +0.01%     
==========================================
  Files         700      702       +2     
  Lines       16653    16681      +28     
==========================================
+ Hits        14808    14835      +27     
- Misses       1845     1846       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 3eb04d5 into solidusio:main Apr 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants