Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Create new Refund Reasons #5696

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

spaghetticode
Copy link
Member

Summary

This PR migrates the creation of new refund reasons to the new admin interface, following the existing pattern used for tax categories.

The form is rendered via a modal dialog on the refund reasons list by leveraging Turbo frames. Successful creation leads to a turbo stream page refresh, which updates the existing list preserving the query params and the scroll position, for a consistent UX.

The attached video shows the functionality visually.

new-refund-reason.mov

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

The form for creating a new refund reason opens in a modal by
leveraging Turbo frames.
This commit completes the process for managing the creation of a new
refund reason. Failures update the form in the existing modal with
the appropriate error messages, while successful creations update the
current page with a Turbo stream refresh and remove the form modal.
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@tvdeyen tvdeyen merged commit 9fb0abb into solidusio:main Apr 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants