Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy App generator: Use db var instead of ENV var #5623

Merged

Conversation

mamhoff
Copy link
Contributor

@mamhoff mamhoff commented Jan 24, 2024

Summary

A couple of lines before this change, we already normalize ENV['db']. We lose that work by relying on the raw ENV var here.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

A couple of lines before this change, we already normalize `ENV['db']`.
We lose that work by relying on the raw ENV var here.
@mamhoff mamhoff requested a review from a team as a code owner January 24, 2024 14:29
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Jan 24, 2024
@spaghetticode spaghetticode added backport-v3.4 Backport this pull-request to v3.4 backport-v4.0 Backport this pull-request to v4.0 backport-v4.1 Backport this pull-request to v4.1 labels Jan 24, 2024
@spaghetticode spaghetticode merged commit 12cb6f2 into solidusio:v4.2 Jan 24, 2024
14 of 15 checks passed
Copy link

💚 All backports created successfully

Status Branch Result
v3.4
v4.0
v4.1

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v3.4 Backport this pull-request to v3.4 backport-v4.0 Backport this pull-request to v4.0 backport-v4.1 Backport this pull-request to v4.1 changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants