Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.3] Theme selection for Solidus Admin: Use spree routing proxy #5605

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

github-actions[bot]
Copy link

Backport

This will backport the following commits from main to v4.3:

Questions ?

Please refer to the Backport tool documentation

When using the navigation from a gem that isolates its namespace in
such a way that the default route helper is not spree, this partial
fails to render with an undefined method error.

This can easily be fixed by prefixing the route helper with Solidus' routing proxy.

This is the same problem and solution as #5599, just for the theme
selection partial that is used when using the current admin (rather than
the new one).

(cherry picked from commit f4c96a8)
@github-actions github-actions bot requested a review from a team as a code owner January 18, 2024 17:44
@github-actions github-actions bot added the changelog:solidus_backend Changes to the solidus_backend gem label Jan 18, 2024
@spaghetticode spaghetticode merged commit 91c2c5f into v4.3 Jan 19, 2024
9 checks passed
@spaghetticode spaghetticode deleted the backport/v4.3/pr-5604 branch January 19, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_backend Changes to the solidus_backend gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants