Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Require ViewComponent v3.9 with inheritable translations #5590

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

elia
Copy link
Member

@elia elia commented Jan 9, 2024

Summary

We no longer need to monkey patch VC translations.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@elia elia self-assigned this Jan 9, 2024
@elia elia requested a review from a team as a code owner January 9, 2024 11:41
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ef5c78) 88.63% compared to head (23e87cc) 88.66%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5590      +/-   ##
==========================================
+ Coverage   88.63%   88.66%   +0.03%     
==========================================
  Files         683      683              
  Lines       16299    16290       -9     
==========================================
- Hits        14446    14443       -3     
+ Misses       1853     1847       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elia thanks!

@elia elia merged commit 64f6a58 into main Jan 9, 2024
14 checks passed
@elia elia deleted the elia/vc-3.9 branch January 9, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants