Hide soft deleted prices from admin product view #4832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `product.prices` relation has been changed in 3f4578a to make eager loading possible, but this now shows soft deleted prices in the admin product prices tab. Hiding them again to restore previous behavior.
tvdeyen
added
changelog:solidus_backend
Codecov Report
@@ Coverage Diff @@
## master #4832 +/- ##
=======================================
Coverage 86.16% 86.16%
=======================================
Files 578 578
Lines 14664 14664
=======================================
Hits 12635 12635
Misses 2029 2029
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jarednorman
approved these changes
Jan 3, 2023
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
product.pricesrelation has been changed in 3f4578a to make eager loading possible, but this now shows soft deleted prices in the admin product prices tab.Hiding them again to restore previous behavior.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):Before
After