Fix Country factory states_required attribute

core/lib/spree/testing_support/factories/state_factory.rb

@@ -17,9 +17,15 @@
       carmen_subregion do
         carmen_country = Carmen::Country.coded(country.iso)
 
-        carmen_country.subregions.coded(state_code) ||
-          carmen_country.subregions.sort_by(&:name).first ||
+        unless carmen_country.subregions?
           fail("Country #{country.iso} has no subregions")
+        end
+
+        carmen_regions = carmen_country.subregions
+        carmen_regions = carmen_regions.flat_map(&:subregions) if carmen_regions.first.subregions?
+        region_collection = Carmen::RegionCollection.new(carmen_regions)
+
+        region_collection.coded(state_code) || region_collection.sort_by(&:name).first
       end
     end
 

core/spec/lib/spree/core/testing_support/factories/state_factory_spec.rb

@@ -33,6 +33,26 @@
     end
   end
 
+  describe 'for a country with nested carmen states' do
+    context 'when not given a state_iso' do
+      let(:state) { build(:state, country_iso: "IT") }
+
+      it 'creates the first state for that country it finds in carmen' do
+        expect(state.abbr).to eq("AL")
+        expect(state.name).to eq("Alessandria")
+      end
+    end
+
+    context 'when given a state_iso' do
+      let(:state) { build(:state, country_iso: "IT", state_code: 'PE' ) }
+
+      it 'finds the corresponding state' do
+        expect(state.abbr).to eq("PE")
+        expect(state.name).to eq("Pescara")
+      end
+    end
+  end
+
   describe 'when given a country record' do
     let(:country) { build(:country, iso: "DE") }
     let(:state) { build(:state, country: country) }