Skip to content

Commit

Permalink
Remove support for Rails v5.2
Browse files Browse the repository at this point in the history
Rails v5.2 is EOL since 01 Jun 2022 [1].

Our new release policy [2] makes it clear that we don't support Rails
versions that are no longer maintained.

[1] - https://endoflife.date/rails
[2] - https://solidus.io/release_policy/
  • Loading branch information
waiting-for-dev committed Jan 12, 2023
1 parent 26f1193 commit 28d72e9
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 14 deletions.
4 changes: 0 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -343,9 +343,5 @@ workflows:
context: slack-secrets
name: *name
matrix: { parameters: { rails: ['6.0'], ruby: ['2.7'], database: ['sqlite'], paperclip: [true] } }
- test_solidus:
context: slack-secrets
name: *name
matrix: { parameters: { rails: ['5.2'], ruby: ['2.7'], database: ['sqlite'], paperclip: [true] } }
- dev_tools:
context: slack-secrets
9 changes: 0 additions & 9 deletions core/lib/spree/core.rb
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,6 @@ class GatewayError < RuntimeError; end
end
end

if Gem::Version.new(Rails.version) < Gem::Version.new('6.0')
Spree::Deprecation.warn <<~HEREDOC
Rails 5.2 (EOL) is deprecated and will not be supported anymore from the next Solidus version.
Please, upgrade to a more recent Rails version.
Read more on upgrading from Rails 5.2 to Rails 6.0 here:
https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-5-2-to-rails-6-0
HEREDOC
end

require 'spree/core/version'

require 'spree/core/active_merchant_dependencies'
Expand Down
2 changes: 1 addition & 1 deletion core/solidus_core.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Gem::Specification.new do |s|
actionmailer actionpack actionview activejob activemodel activerecord
activesupport railties
].each do |rails_dep|
s.add_dependency rails_dep, ['>= 5.2', '< 7.1.x']
s.add_dependency rails_dep, ['>= 6.0', '< 7.1.x']
end

s.add_dependency 'activemerchant', '~> 1.66'
Expand Down

0 comments on commit 28d72e9

Please sign in to comment.