Modify auth_type enum syntax for Rails compatibility #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enum syntax changes in Rails 8. Additionally, the token.rb file had a duplicate declaration that we can clean up.
skukx
approved these changes
Sep 12, 2025
|
@skukx Thanks for the quick approval. I'll take a stab at fixing the CI issues as well. Will convert to draft in the meantime. |
|
I had to make a few extra changes to get everything working on CI. If you need me to split up into multiple PRs let me know. There were a lot of rubocop autocorrect changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enum syntax changes in Rails 8, causing this gem to fail.
Additionally, the token.rb file had a duplicate declaration that we can clean up since one was dead code.