feat(GoogleMerchant): Allow to load products via scope. #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all products are loaded from the database during application boot, because we yield the block when we
register a feed.
This is far from ideal! Especially if you want to boot the app to prepare specs or build assets on heroku or in a docker container.
I think we can agree that accessing the database during app boot is generally a bad idea.
Current fix
One could prevent accessing the database by using this little hack
but this does not feel quite right.
Proposed fix
Instead let's allow to pass a
product_scope
instead of products. By usingavailable
as default scope we do what most stores want anyway.So, it now gets as simple as
or pass your custom scope