Skip to content

Conform proxies to ERC1967 and add transparent proxies#292

Merged
ItsNickBarry merged 45 commits into
masterfrom
eip-1967
Mar 30, 2025
Merged

Conform proxies to ERC1967 and add transparent proxies#292
ItsNickBarry merged 45 commits into
masterfrom
eip-1967

Conversation

@ItsNickBarry
Copy link
Copy Markdown
Member

Proxies no longer use Ownable for upgrades (includeing diamondCut).

Storage layout seed string format has been changed to solidstate.layout.[name] because I thought it would be funny if ERC1967Storage complied with both ERC1967 and ERC7201, and I needed the resulting value to be less than the ERC1967 implementation slot.

@ItsNickBarry
Copy link
Copy Markdown
Member Author

ItsNickBarry commented Mar 23, 2025

I would like to add a UUPS-style proxy, but ERC-1822 is not a real standard, and it contradicts ERC-1967.

I would also like to move the transparent proxy admin functions into a shared module, but there's no logical place to put it. This would also allow adding an equivalent to SafeOwnable.

@ItsNickBarry
Copy link
Copy Markdown
Member Author

It would be nice if DiamondBeacon inherited from Beacon, but that would involve appending function signature as metadata to the implementation() function. Might make sense if a beacon equivalent of DiamondFallback were added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant