Skip to content

Support custom error #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Support custom error #7

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
870e887
Support custom error
nxqbao Jan 4, 2023
bc6e028
using forEach instead of map
nxqbao Apr 12, 2023
2486c8a
add in-line comment
nxqbao Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tasks/upload_selectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,15 @@ task(
}));

const compositeAbi = Object.values(elements).filter(function (el) {
return el.type === 'function' || el.type === 'event';
return el.type === 'function' || el.type === 'event' || el.type === 'error';
});

compositeAbi.forEach(function (el) {
// We convert all errors to 'function' type, since 4byte.directory not support ABIs that include errors and both types are encoded in the same way.
if (el.type === 'error') {
el.type = 'function';
el.outputs = []
}
});

if (compositeAbi.length === 0) {
Expand Down