Skip to content

Remove .env file creation #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 18, 2023
Merged

Remove .env file creation #409

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
152145a
Remove .env file generation from entrypoint
rjhenry Jul 3, 2023
7d861ff
Create function to check if vars exist
rjhenry Jul 3, 2023
03907dd
Ensure a number of variables exist
rjhenry Jul 3, 2023
ac5dac2
Add env vars to docker-compose
rjhenry Jul 3, 2023
0728a23
Patch test compose file to specify required vars
rjhenry Jul 5, 2023
c5219c8
Make note of required arguments
rjhenry Jul 5, 2023
ab52487
Add notes on breaking change
rjhenry Jul 5, 2023
f533881
Adjust entrypoint script to move env file instead of removing
rjhenry Jul 7, 2023
2bfe6aa
Remove key generation from entrypoint script
rjhenry Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make note of required arguments
  • Loading branch information
@rjhenry
rjhenry committed Jul 18, 2023
commit c5219c8ec331586dbde6d87b71e07700846d51d2
10 changes: 9 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,14 @@ Networking changed in Docker v1.9, so you need to do one of the following steps.

`APP_URL=http://example.com`

The following environment variables are required for Bookstack to start:
- `APP_KEY`
- `APP_URL`
- `DB_HOST` (in the form `${hostname_or_ip_address}:${port}`)
- `DB_DATABASE`
- `DB_USERNAME`
- `DB_PASSWORD`

### Volumes

To access your `.env` file and important bookstack folders on your host system
Expand All @@ -115,7 +123,7 @@ your run command:
In case of a windows host machine the .env file has to be already created in the
host directory otherwise a folder named .env will be created.

After these steps you can visit [http://localhost:8080](http://localhost:8080) .
After these steps you can visit [http://localhost:8080](http://localhost:8080).
You can login with username `admin@admin.com` and password `password`.

## Inspiration
Expand Down