Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jsx-dev-runtime #1393

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Conversation

manucorporat
Copy link
Contributor

Summary

JSX-automatic is missing the jsx-dev-runtime, esencially breaking solid when using jsx-runtime in development mode. External tooling will expect this file to exisit.

@coveralls
Copy link

coveralls commented Dec 5, 2022

Pull Request Test Coverage Report for Build 3612737076

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.125%

Totals Coverage Status
Change from base Build 3537603104: 0.0%
Covered Lines: 1282
Relevant Lines: 1368

💛 - Coveralls

@ryansolid ryansolid merged commit 2f11ee1 into solidjs:main Dec 5, 2022
@ryansolid
Copy link
Member

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants