DEV: Add a way to observe stores#1307
Merged
ryansolid merged 4 commits intosolidjs:mainfrom Nov 11, 2022
Merged
Conversation
Adds a dev-only ability to observe stores by adding a new `$ON_UPDATE` symbol. Add off the dev APIs are bundled into DEV object, as in core module Some typings got impored too Added a jsdoc comment to `unwrap` as well
Pull Request Test Coverage Report for Build 3385674394Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
17 tasks
Contributor
Author
|
Alright, I think this one's ready |
lilybw
pushed a commit
to lilybw/solid
that referenced
this pull request
Nov 12, 2025
* dev: Add a way to observe stores, export DEV object Adds a dev-only ability to observe stores by adding a new `$ON_UPDATE` symbol. Add off the dev APIs are bundled into DEV object, as in core module Some typings got impored too Added a jsdoc comment to `unwrap` as well * Correct changed produce types * Change the OnStoreNodeUpdate arguments * Change to global listener for stoes, add test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a dev-only ability to observe stores by adding a new$ON_UPDATEsymbol.DEVobject, as in the core module (not sure if it should be calledSTORE_DEVto avoid conflicts, but it's probably whatever)unwrapbecause why notDraft because I still want to confirm if this is enough, and maybe add some unit tests.