fix: collect CSS with shared chunk name#2032
Merged
Conversation
🦋 Changeset detectedLatest commit: e612efd The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
katywings
added
bug
commit: |
katywings
changed the title
katywings
force-pushed
the
fix-shared-chunk-css
branch
from
33c80ed to
042f6b8
Compare
katywings
force-pushed
the
fix-shared-chunk-css
branch
from
042f6b8 to
c26a2a3
Compare
katywings
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
CSS from lazy modules in shared chunks is not server rendered, resulting in a flash of unstyled content.
What is the new behavior?
CSS from lazy modules in shared chunks is server rendered.
Other information
When integrating solid-lazy-plus into SolidStart via #1965, I left away the special logic for shared chunks from https://codeberg.org/lufrai/solid-lazy-plus/src/commit/24ec2f7162806dc20845466ed9c049eb1a5bc982/src/vite.ts#L14 as I thought it wasn't needed anymore. Apparently it is still needed 😅.
The fix in devinxied SolidStart is a bit more involved, because Vinxi in PROD allowed the CSS crawling in the server and client manifest, devinxied SolidStart on the other hand only has the client manifest. That's why we have to collect the client chunk names, so that they afterwards can be used in the server code.