Write event.response.headers to returned Responses#2011
Merged
Brendonovich merged 5 commits intomainfrom Nov 23, 2025
Merged
Conversation
|
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
atilafassina
approved these changes
Nov 23, 2025
6113e0a to
8992c20
Compare
Contributor
|
doesn't h3 v2 already do this? |
Collaborator
Author
|
@huseeiin Not in 100% of cases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a Response is returned from an API route or server function, any headers written via
@solidjs/start/httpincludinguseSessionare not passed on. This writes headers fromgetRequestEvent().responseto the returned response, if the header doesn't already exist on the returned response.In the case of redirects being returned, we clone the response in case it is immutable (such as those returned from
Response.redirect)