add nitro 3 fixture - fix landing page build#2008
Merged
atilafassina merged 7 commits intomainfrom Nov 23, 2025
Merged
Conversation
|
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atilafassina
force-pushed
the
fixtures/consume-from-workspace
branch
4 times, most recently
from
67d5ca6 to
0d793ac
Compare
commit: |
atilafassina
force-pushed
the
fixtures/consume-from-workspace
branch
2 times, most recently
from
dfa12cb to
ef11bc6
Compare
atilafassina
changed the title
Brendonovich
force-pushed
the
fixtures/consume-from-workspace
branch
from
8f98359 to
f60db4a
Compare
brenelz
approved these changes
Nov 22, 2025
Contributor
brenelz
left a comment
brenelz
left a comment
There was a problem hiding this comment.
Nice work here. One conflict to resolve
atilafassina
force-pushed
the
fixtures/consume-from-workspace
branch
from
f60db4a to
e5be5a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we have been consuming start and the nitro plugin from
/src, this PR changes the exports in the start package so it can also be consumed from/dist.it also adds a dedicated fixture for Nitro v3