Add useMatches hook to expose router matches#420
Closed
oscartbeaumont wants to merge 2 commits intosolidjs:mainfrom
Closed
Add useMatches hook to expose router matches#420oscartbeaumont wants to merge 2 commits intosolidjs:mainfrom
useMatches hook to expose router matches#420oscartbeaumont wants to merge 2 commits intosolidjs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 68f50fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
useMatches hook to expose router matchesuseMatches hook to expose router matches
3 tasks
Author
|
Turns out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
useMatcheshook which exposes the router's matches.Usecase
I think this is very useful for implementing a breadcrumb system.
Our pages have something along the lines of:
and then with the
useMatcheshook this PR implements, our breadcrumb component can be implemented as such:We are actively using these changes in our codebase and it would be really nice to upstream these changes so we don't require a fork. The codebase is open source if it provides more context to our usage. The Breadcrumb component and an example
route export.Prior Art
React Router has a similar feature useMatches. These docs even showcase a Breadcrumb system similar to what I show above.