fix: merge class in classList to avoid conflict between them#182
Merged
ryansolid merged 1 commit intosolidjs:mainfrom Oct 16, 2022
100terres:fix-181-conflict-between-external-reactive-class-prop-and-internal-class-list-prop-of-a-link-and-nav-link-components
Merged
fix: merge class in classList to avoid conflict between them#182ryansolid merged 1 commit intosolidjs:mainfrom 100terres:fix-181-conflict-between-external-reactive-class-prop-and-internal-class-list-prop-of-a-link-and-nav-link-components
ryansolid merged 1 commit intosolidjs:mainfrom
100terres:fix-181-conflict-between-external-reactive-class-prop-and-internal-class-list-prop-of-a-link-and-nav-link-components
Conversation
fix #181 Using reactive class can have unexpected behavior when used in combination with a classList.
Brendan-csel
pushed a commit
to cselnz/solid-router
that referenced
this pull request
Oct 18, 2022
…#182) fix solidjs#181 Using reactive class can have unexpected behavior when used in combination with a classList.
ryansolid
pushed a commit
that referenced
this pull request
Nov 21, 2022
* fix: merge class in classList to avoid conflict between them (#182) fix #181 Using reactive class can have unexpected behavior when used in combination with a classList. * Support for blocking navigation (onBeforeLeave hook) * useBeforeLeave - allow retry without forcing * Use Set to clean up leave handlers * useBeforeLeave needs "from" (after real-world testing) * Shink if to boolean guard style * Refactor BeforeLeave to be Router instance specific * Previous refactor allows BeforeLeave to provide full Location from router (and reduce work for integrations) * Exposing whole router context to BeforeLeave seems leaky * Retrying BeforeLeave must ignore next confirm (could be from an async event) Co-authored-by: Gab <gab@100terres.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #181
Using reactive class can have unexpected behavior when used in combination with a classList.