Skip to content

Improve main header button design #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

marvin-j97
Copy link
Contributor

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

Replaces the bottom border with a glassy background color, which looks better and has better on hover feedback.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Jun 3, 2025

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit b8bc98a
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/6843dc0dccb7cf0008ea23ae
😎 Deploy Preview https://deploy-preview-1194--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@amirhhashemi
Copy link
Collaborator

amirhhashemi commented Jun 7, 2025

I personally like this. However, we generally do not accept pull requests that alter the website's design. Design is highly subjective, and allowing design PRs could quickly lead to inconsistencies in our overall look and feel. While your design may appear better, it still doesn't align well with the design of the other buttons on the website.

I understand that our design isn't the most consistent, and I've voiced my own criticisms in the past. Nevertheless, for the reasons mentioned, I prefer to close this PR. Please feel free to share your feedback on Discord. In the next redesign of the website, or whenever a team member has some free time, we will try to address these concerns.

I also want to express my appreciation for the effort you put into this project. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants