Open
Conversation
This prevents a permanent diff when the list of either initiators or volumes is sorted differently from what the API returns
Currently the puppet output when initiators or volumes change in a volume access group is a very hard to read output of an array. This changes it to only show what's different, making it much more readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things to improve the ability to use volume access groups:
Sort the list of VAG initiators and volumes when checking if in sync
This prevents a permanent diff when the list of either initiators or
volumes is sorted differently from what the API returns
Improve readability of changes in VAG initiators and volumes
Currently the puppet output when initiators or volumes change in a
volume access group is a very hard to read output of an array. This
changes it to only show what's different, making it much more readable.