Skip to content
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.

recommendations-server: better example domains #124

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

sourcejedi
Copy link
Contributor

We need more than one example domain. .example TLD is defined for this purpose. Let's use it.

https://tools.ietf.org/html/rfc2606 - "Reserved Top Level DNS Names".

Also add missing quotes around one URI. We do not want these URIs to be clickable.

Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea that we use .example for those where we use an invalid domain, but since example.org is a valid domain to use in the same context per the RFC, I think we might as well keep that. But my opinion isn't strong, so lets await more reviews.

request.

3. The server responds to the request and sets the value of the request `Origin`
header to the CORS header in the HTTP response:

```http
Access-Control-Allow-Origin: https://app.org
Access-Control-Allow-Origin: https://example.app
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This came out wrong, though :-)

We need more than one example domain. `.example` TLD is defined for this
purpose.  Let's use it.

https://tools.ietf.org/html/rfc2606 - "Reserved Top Level DNS Names".

Also add missing quotes around one URI. We do not want these URIs to be
clickable.
@sourcejedi
Copy link
Contributor Author

sourcejedi commented Nov 15, 2018

I've fixed my mistake :-).

I don't understand. Do you mean to use example.org and app.example as the two domains?

example.org was fine, but then it means http://app.org is confusing. It is not an RFC-reserved example domain. It doesn't show anything to do with the SOLID spec either. Maybe it is a SOLID domain and you plan to make it make more sense in future? but this is not clear to me as a reader at the moment... And if SOLID has set up a domain they are using to represent apps, it makes you wonder why there is not a SOLID-specific domain to represent servers?

(edited: the domain used was "example.org" not "example.net", sorry).

@kjetilk
Copy link
Member

kjetilk commented Nov 15, 2018

I've fixed my mistake :-).

Great! :-)

example.net was fine, but then it means http://app.org is confusing.

Yeah, what I meant was using example.org and app.example.

Copy link
Member

@justinwb justinwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjetilk kjetilk added the Quick Merge pull requests that can be merged in three days label Apr 15, 2019
@Mitzi-Laszlo Mitzi-Laszlo added this to the Spec Pull Requests milestone May 7, 2019
Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this is good to go.

@kjetilk kjetilk merged commit 2a93cc4 into solid:master Jun 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Quick Merge pull requests that can be merged in three days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants