-
Notifications
You must be signed in to change notification settings - Fork 103
recommendations-server: better example domains #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea that we use .example
for those where we use an invalid domain, but since example.org is a valid domain to use in the same context per the RFC, I think we might as well keep that. But my opinion isn't strong, so lets await more reviews.
recommendations-server.md
Outdated
request. | ||
|
||
3. The server responds to the request and sets the value of the request `Origin` | ||
header to the CORS header in the HTTP response: | ||
|
||
```http | ||
Access-Control-Allow-Origin: https://app.org | ||
Access-Control-Allow-Origin: https://example.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This came out wrong, though :-)
We need more than one example domain. `.example` TLD is defined for this purpose. Let's use it. https://tools.ietf.org/html/rfc2606 - "Reserved Top Level DNS Names". Also add missing quotes around one URI. We do not want these URIs to be clickable.
I've fixed my mistake :-). I don't understand. Do you mean to use
(edited: the domain used was "example.org" not "example.net", sorry). |
Great! :-)
Yeah, what I meant was using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, this is good to go.
We need more than one example domain.
.example
TLD is defined for this purpose. Let's use it.https://tools.ietf.org/html/rfc2606 - "Reserved Top Level DNS Names".
Also add missing quotes around one URI. We do not want these URIs to be clickable.