Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: turn off dependabot #438

Merged
merged 4 commits into from
Oct 4, 2023
Merged

ci: turn off dependabot #438

merged 4 commits into from
Oct 4, 2023

Conversation

Vahid1919
Copy link
Contributor

Description:

Stopped dependabot from carrying out any additional PRs. Closes #437

Definition of Reviewable:

PR notes: Irrelevant elements should be removed.

  • relevant tickets are linked
  • PR is assigned to project board

@Vahid1919 Vahid1919 linked an issue Sep 28, 2023 that may be closed by this pull request
6 tasks
@Vahid1919 Vahid1919 requested a review from a team September 28, 2023 08:54
@Vahid1919
Copy link
Contributor Author

@solid-design-system/development Please Review :)

@azraefendic azraefendic removed their assignment Sep 29, 2023
@mariohamann
Copy link
Contributor

CleanShot 2023-09-29 at 08 34 24@2x

What is with this stuff? Do we need this, if dependabot is deactivated?

Can't we just revert the commit from some weeks ago, that we resettle this at another point?

mariohamann

This comment was marked as duplicate.

@Vahid1919
Copy link
Contributor Author

CleanShot 2023-09-29 at 08 34 24@2x What is with this stuff? Do we need this, if dependabot is deactivated?

Can't we just revert the commit from some weeks ago, that we resettle this at another point?

@mariohamann We won't need while dependabot is on.
Reverting the commit is one option, but we could also just disable them for the repository and leave a note on #416 to turn them on after dependabot gets fixed?

@mariohamann
Copy link
Contributor

What holds you back from making a revert commit and just linking the commit to the issue?

Currently we neither need the actions in the PR nor the Dependabot behaviour. On top we maybe will even switch to Renovate or have to rethink our process, therefore I don't see much value in leaving the stuff in code if might even be completely changed at a later point.

What are your toughts on that? :)

@Vahid1919
Copy link
Contributor Author

What holds you back from making a revert commit and just linking the commit to the issue?

Currently we neither need the actions in the PR nor the Dependabot behaviour. On top we maybe will even switch to Renovate or have to rethink our process, therefore I don't see much value in leaving the stuff in code if might even be completely changed at a later point.

What are your toughts on that? :)

Okay I think in that case a revert makes sense. I didn't consider the possibility of moving to renovate. I didn't believe it was necessary to revert everything if we are putting it back after a fix (since the changes also includes some documentation).

But since, that's undecided I'll go ahead and do the revert.

@Vahid1919 Vahid1919 self-assigned this Oct 2, 2023
@mariohamann mariohamann removed their assignment Oct 4, 2023
@Vahid1919 Vahid1919 merged commit 963a96e into main Oct 4, 2023
10 checks passed
@Vahid1919 Vahid1919 deleted the ci/turn-off-dependabot branch October 4, 2023 08:14
yoezlem pushed a commit that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

ci: 👷 Turn off dependabot
5 participants