fix: sd-input a11y #1615
Open
fix: sd-input a11y #1615
+358
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smfonseca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
smfonseca
assigned mariohamann, coraliefeil, smfonseca, Vahid1919, auroraVasconcelos and MartaPintoTeixeira
|
🚀 Storybook has been deployed for branch |
This reverts commit 5cc342b.
|
Checked. No todos on our end needed. |
smfonseca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
smfonseca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
smfonseca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
MartaPintoTeixeira
previously approved these changes
Nov 7, 2024
paulovareiro29
requested changes
Nov 11, 2024
| render: () => | ||
| html`<div class="flex flex-rows gap-12"> | ||
| <sd-input label="Label" spellcheck> | ||
| <sd-icon label="landscape" library="global-resources" name="system/picture" slot="left"></sd-icon> |
There was a problem hiding this comment.
library="global-resources" is deprecated, no library is needed to be referenced. the icon name may be different, check the figma.
There was a problem hiding this comment.
Thanks for the information @auroraVasconcelos. Was this documented somewhere that I may have missed it? I still see lots of places in the codebase with this.
Co-authored-by: Paulo Vareiro <58229468+paulovareiro29@users.noreply.github.com>
# Conflicts: # packages/docs/src/stories/templates/input.stories.ts
smfonseca
temporarily deployed
to
github-pages
GitHub Actions
Inactive
paulovareiro29
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR closes 1479 and 1520
It also introduces custom spin buttons for number inputs which improves the component accessibility since now all changes in a type="number" input are correctly announced by screen readers.
@MartaPintoTeixeira @coraliefeil in this PR there are copy changes, mainly for
max-lengthandmin-length. Please consider them to align with Figma. If you have any questions, please let me know.-> Checked. No todos on our end needed.
Definition of Reviewable: