Skip to content

sync trial cached analyses output deletion with trial data deletion#6170

Open
isaak wants to merge 58 commits into
masterfrom
topic/solgs/add-clear-cache
Open

sync trial cached analyses output deletion with trial data deletion#6170
isaak wants to merge 58 commits into
masterfrom
topic/solgs/add-clear-cache

Conversation

@isaak

@isaak isaak commented Jun 22, 2026

Copy link
Copy Markdown
Member

Description

-- When trial and dataset data is deleted (at least from the user interface), clear all trial related cached analysis output (GS, correlation, anova, pca, clustering, kinship, genetic gain, heritability)

-- refactor analyses cache and tempfiles dirs structure. Now trial analyses output are stored in a trial specific dir (e.g., ~/volume/tmp/[hostname]/[genetype_protocol_name]/[analysis_type]/trials/[trial_id]/, ~/volume/tmp/breedbase.org/GBSApeKIgenotypingv4/solgs/trials/489/cache)

-- update and pass all analyses selenium tests

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@isaak isaak changed the title Topic/solgs/add clear cache Clear trial cached analyses output when trial data is deleted Jun 22, 2026
@isaak isaak changed the title Clear trial cached analyses output when trial data is deleted sync trial cached analyses output deletion with trial data deletion Jun 22, 2026
@ryan-preble

Copy link
Copy Markdown
Contributor

Question: is this meant to work only with trials or is dataset deletion also supposed to trigger cache deletion? I ran a cluster analysis with outliers_test_dataset (which includes Kasese solgs trial). Neither deleting the trial nor the dataset cleared the cached analysis. Is this intentional?

@isaak

isaak commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

Question: is this meant to work only with trials or is dataset deletion also supposed to trigger cache deletion? I ran a cluster analysis with outliers_test_dataset (which includes Kasese solgs trial). Neither deleting the trial nor the dataset cleared the cached analysis. Is this intentional?

Updated...deleting a dataset should now delete also cached analyses results from the same dataset. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants