Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow loan_to_value_ratio == liquidation_threshold #85

Merged
merged 1 commit into from
May 24, 2022
Merged

allow loan_to_value_ratio == liquidation_threshold #85

merged 1 commit into from
May 24, 2022

Conversation

nope-finance
Copy link
Member

No description provided.

oxrooter
oxrooter approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@oxrooter oxrooter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would allow a pool to be created in which users are liquidatable immediately after opening a position. Could be a concern for a honeypot permissionless pool, but seems unlikely/unimportant enough. LGTM.

@nope-finance nope-finance merged commit 17ee8d5 into upcoming May 24, 2022
@0xripleys 0xripleys deleted the ltv_equal_max branch January 25, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxrooter oxrooter oxrooter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nope-finance @oxrooter