Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added liquidate and redeem (with protocol fee) #75
added liquidate and redeem (with protocol fee) #75
Changes from 1 commit
1ec2747
8cad944
7c7a2a1
bb3b9e6
353e710
594fac8
409a022
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than withdrawing collateral during
_liquidate_obligation
and then burning the collateral in_redeem_reserve_collateral
, you could save a CPI by just directly burning from the reserve's collateral supply. And on this subject, there is some other redundant work done in both_liquidate_obligation
and_redeem_reserve_collateral
(notably the PDA creation) that could be saved with some more work as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeh I think the reasoning i had for doing this way was to be more modular and write as little new math/logic code as possible not optimize compute (beyond sticking to < 200k ish). but perhaps there is some level of optimization that could be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, optimizations can easily introduce critical bugs as well, so there's a trade-off