Liquidation protocol fee #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nope-finance
force-pushed
the
liquidation-protocol-fee2
branch
2 times, most recently
from
1915cd3 to
2d0a637
Compare
…ruction, adding 1 missing access check
nope-finance
force-pushed
the
liquidation-protocol-fee2
branch
from
2d0a637 to
2fd17da
Compare
DaSichuan
reviewed
Feb 17, 2022
| _padding, | ||
| liquidity_accumulated_protocol_fees, |
DaSichuan
reviewed
Feb 17, 2022
| protocol_fee_amount = 1; | ||
| } | ||
|
|
||
| let withdraw_amount = withdraw_amount.saturating_sub(protocol_fee_amount); |
There was a problem hiding this comment.
Nit: why redefine withdraw_amount here?
DaSichuan
reviewed
Feb 17, 2022
| let mut protocol_fee_amount = bonus_amount.try_mul(protocol_fee_rate)?.try_floor_u64()?; | ||
| // minimum protocol fee | ||
| if protocol_fee_amount == 0 { | ||
| protocol_fee_amount = 1; |
There was a problem hiding this comment.
Doesn't enforcing a minimum protocol fee amount completely disincentive liquidators from liquidating sufficiently small liquidations?
I know they don't really go after the small ones anyway, but it seems like we might not want to have 0 incentivize liquidation opportunities maybe?
idk
There was a problem hiding this comment.
Also the liquidation will fail if withdraw_amount is 0
There was a problem hiding this comment.
this only affects the smallest of liquidations, which no one is incentivized to do anyway. wont liquidations already fail if withdraw amount is 0? (if you look in processor)
DaSichuan
reviewed
Feb 17, 2022
DaSichuan
reviewed
Feb 17, 2022
nope-finance
force-pushed
the
liquidation-protocol-fee2
branch
from
284b309 to
17ac101
Compare
|
#75 addresses this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.