adding confidence and status checks for pyth #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nope-finance
force-pushed
the
pyth_confidence_and_status
branch
from
0207445 to
7d931e0
Compare
nope-finance
force-pushed
the
pyth_confidence_and_status
branch
from
7d931e0 to
5c2f84f
Compare
DaSichuan
requested changes
Dec 10, 2021
| if conf.checked_mul(confidence_ratio).unwrap() > price { | ||
| msg!( | ||
| "Oracle price confidence is too wide: {}", | ||
| pyth_price.agg.status as u8 |
There was a problem hiding this comment.
Isn't this always just going to be pyth::PriceStatus::Trading?
Seems better to log conf and price
There was a problem hiding this comment.
ah yeah meant to do that
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ran tests for token-lending locally (i know the git hooks dont work not but are resolved in other branch)