Add ability to update oracle addresses #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaSichuan
commented
Aug 18, 2021
| @@ -2034,6 +1991,18 @@ fn process_update_reserve_config( | |||
| ); | |||
| return Err(LendingError::InvalidMarketAuthority.into()); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This is a bit hacky, and I don't love it.
The logic is basically
If 1 optional address is supplied, assume it's [switchboard]
If 2 optional addresses are supplied, assume its [pyth_product, pyth price]
If 3 optional addresses are supplied, assume it's [pyth_product, pyth_price, switchboard]
There was a problem hiding this comment.
i think perhaps it would be better if always had to pass 3 things but we could check if they were like default values
There was a problem hiding this comment.
Did something slightly different.
I made it such that if new addresses aren't specified, then it calls the instruction with the old oracle addresses and a bogus address as the pyth product address.
nope-finance
approved these changes
Aug 18, 2021
DaSichuan
force-pushed
the
WM_update_oracle
branch
from
1402b08 to
bf7dac4
Compare
Please enter the commit message for your changes. Lines starting
DaSichuan
force-pushed
the
WM_update_oracle
branch
from
bf7dac4 to
6ab9d7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to update oracle addresses.
Currently pretty hard to test because of all the validation that happens on the new addresses.
Not really sure the best way to test this yet.