Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check switchboard program id #25

Merged
merged 4 commits into from
Jul 30, 2021
Merged

check switchboard program id #25

merged 4 commits into from
Jul 30, 2021

Conversation

nope-finance
Copy link
Member

No description provided.

@nope-finance nope-finance force-pushed the check_switchboard_id branch from ef858bb to cce3877 Compare July 28, 2021 03:33
@nope-finance nope-finance force-pushed the check_switchboard_id branch from cce3877 to 8973fc7 Compare July 28, 2021 03:54
@nope-finance nope-finance requested a review from DaSichuan July 28, 2021 05:22
Copy link

@DaSichuan DaSichuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just nits

@@ -300,6 +302,10 @@ fn process_init_reserve(
return Err(LendingError::InvalidOracleConfig.into());
}

if &lending_market.switchboard_oracle_program_id != switchboard_feed_info.owner {
msg!("Pyth price account provided is not owned by the lending market oracle program");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Pyth"

@@ -521,6 +525,7 @@ impl TestLendingMarket {
authority: lending_market_authority,
quote_currency: QUOTE_CURRENCY,
oracle_program_id,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add the key here? pyth_oracle_program_id or whatever it is
just so it matches

@@ -783,6 +788,7 @@ impl TestReserve {
payer: &Keypair,
user_accounts_owner: &Keypair,
) -> Result<Self, TransactionError> {
print!("asdfasd1");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm

@nope-finance nope-finance merged commit 34a0c7c into staging Jul 30, 2021
@nope-finance nope-finance deleted the check_switchboard_id branch July 30, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants