Skip to content

Conversation

@febo
Copy link
Contributor

@febo febo commented Apr 22, 2025

Problem

The tests on p-token used to run both SPL Token and p-token using the test_case crate as a "conformance" test. Since it now uses fixtures for that, the test_case annotation is redundant.

Solution

Clean-up the tests, removing the test_case annotation and dependency.

@febo febo changed the base branch from main to febo/mint-as-authority April 22, 2025 14:30
@febo febo marked this pull request as ready for review April 22, 2025 14:35
@febo febo requested a review from joncinque April 22, 2025 14:35
joncinque
joncinque previously approved these changes Apr 22, 2025
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Base automatically changed from febo/mint-as-authority to main April 30, 2025 11:26
@febo febo dismissed joncinque’s stale review April 30, 2025 11:26

The base branch was changed.

@febo febo requested a review from joncinque April 30, 2025 11:53
@febo
Copy link
Contributor Author

febo commented Apr 30, 2025

Rebased.

@febo febo merged commit feb11f8 into main Apr 30, 2025
15 checks passed
@febo febo deleted the febo/test-case-annotation branch April 30, 2025 21:10
@evandrofgarcia

This comment was marked as spam.

@solana-program solana-program locked as resolved and limited conversation to collaborators Jul 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants