program: Fix off-by-one error #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem A buffer with 166 bytes is counted as invalid, but a buffer with 167 bytes is ok. This doesn't really make sense, because a buffer with 167 bytes wouldn't have room for the first type in the TLV structure. #### Summary of changes Remove the off-by-one-error by changing `<=` to `<`
2501babe
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A buffer with 166 bytes is counted as invalid, but a buffer with 167 bytes is ok. This doesn't really make sense, because a buffer with 167 bytes wouldn't have room for the first type in the TLV structure.
Summary of changes
Remove the off-by-one-error by changing
<=to<.NOTE: Since there's currently no situation where it makes sense to have an account with 166 or 167 bytes, this shouldn't have any end-user impact, but it's better for the code to be correct.