Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nits for sanitize trait #9741

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Nits for sanitize trait #9741

merged 1 commit into from
Apr 30, 2020

Conversation

aeyakovenko
Copy link
Member

Problem

Docs and nits for the sanitize trait

Summary of Changes

  1. remove generic failure
  2. use this error
  3. propagate the sanitize call to all members

Fixes #

@aeyakovenko aeyakovenko requested review from garious and jackcmay April 27, 2020 20:56
@codecov
Copy link

codecov bot commented Apr 27, 2020 •
edited
Loading

Codecov Report

Merging #9741 into master will increase coverage by 0.0%.
The diff coverage is 75.0%.

@@          Coverage Diff           @@
##           master   #9741   +/-   ##
======================================
  Coverage    80.4%   80.4%           
======================================
  Files         281     281           
  Lines       64644   64661   +17     
======================================
+ Hits        51975   51994   +19     
+ Misses      12669   12667    -2

jackcmay
jackcmay previously approved these changes Apr 28, 2020
View reviewed changes
garious
garious reviewed Apr 28, 2020
View reviewed changes
core/src/crds_value.rs Outdated Show resolved Hide resolved
@mergify mergify bot dismissed jackcmay’s stale review April 29, 2020 22:59

Pull request has been modified.

@aeyakovenko aeyakovenko added the automerge Merge this Pull Request automatically once CI passes label Apr 29, 2020
@solana-grimes solana-grimes merged commit a0514eb into solana-labs:master Apr 30, 2020
mergify bot pushed a commit that referenced this pull request Apr 30, 2020
@aeyakovenko
thiserror, docs, remove general Failure case (#9741)
8ca451b 
automerge

(cherry picked from commit a0514eb)

# Conflicts:
#	core/src/crds_value.rs
#	core/src/epoch_slots.rs
#	sdk/src/sanitize.rs
@mergify mergify bot mentioned this pull request Apr 30, 2020
Merged
mergify bot pushed a commit that referenced this pull request Apr 30, 2020
@aeyakovenko
thiserror, docs, remove general Failure case (#9741)
01460a5 
automerge

(cherry picked from commit a0514eb)
@mergify mergify bot mentioned this pull request Apr 30, 2020
Merged
solana-grimes pushed a commit that referenced this pull request Apr 30, 2020
@mergify
thiserror, docs, remove general Failure case (#9741) (#9810)
7a6543e 
automerge
mvines added a commit that referenced this pull request Apr 30, 2020
@mergify @aeyakovenko @mvines
Nits for sanitize trait (bp #9741) (#9809)
5bc57ea 
* thiserror, docs, remove general Failure case (#9741)

automerge

(cherry picked from commit a0514eb)

# Conflicts:
#	core/src/crds_value.rs
#	core/src/epoch_slots.rs
#	sdk/src/sanitize.rs

* rebase

Co-authored-by: anatoly yakovenko <anatoly@solana.com>
Co-authored-by: Michael Vines <mvines@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garious garious garious left review comments

@jackcmay jackcmay jackcmay left review comments

Assignees
No one assigned
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aeyakovenko @garious @jackcmay @mvines @solana-grimes