This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Deprecate confirmTransaction, getSignatureStatus, and getSignatureConfirmation
#9298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
changed the title
confirmTransaction and getSignatureStatusconfirmTransaction, getSignatureStatus, and getSignatureConfirmation
Codecov Report
@@ Coverage Diff @@
## master #9298 +/- ##
========================================
- Coverage 80.9% 80.8% -0.1%
========================================
Files 276 276
Lines 61208 61193 -15
========================================
- Hits 49551 49490 -61
- Misses 11657 11703 +46 |
client/src/rpc_client.rs
Outdated
| ) | ||
| .map_err(|err| err.into_with_command("ConfirmTransaction"))?; | ||
| let Response { context, value } = | ||
| self.get_signature_statuses(&[*signature], commitment_config)?; |
There was a problem hiding this comment.
Update method name as per suggestion below
mvines
previously approved these changes
Apr 4, 2020
mvines
added
automerge
solana-grimes
removed
the
automerge
|
💔 Unable to automerge due to CI failure |
| #[rpc(meta, name = "getSignatureStatuses")] | ||
| fn get_signature_statuses( | ||
| fn get_signature_statuses_with_commitment( |
There was a problem hiding this comment.
I only intended this name change in rpc_client. This is actually not consistent with the rest of the rpc methods. Will revert as part of transaction-history work.
danpaul000
pushed a commit
to danpaul000/solana
that referenced
this pull request
Jul 8, 2020
…reConfirmation` (solana-labs#9298) * Deprecate `confirmTransaction`, `getSignatureStatus`, etc * Rename get_signature_statuses to get_signature_statuses_with_commitment Co-authored-by: Michael Vines <mvines@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Various client JSON RPC libraries appear to have problems processing the
status: { "Ok": null }transaction status returned by methods such asgetSignatureStatuses. Thenullvalue causes the removal ofOkentirely and the client ends up with a status object of{}.We don't know who is using these two endpoints so we'll have to support them for now, but we should actively discourage anyone from using them from this point forward.
Summary of Changes
Related to: #9297